riscv64: Add SIMD avg_round#6599
Merged
Merged
Conversation
afonso360
added
the
cranelift:area:riscv64
github-actions
Bot
added
the
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR implements the SIMD
avg_roundinstruction. We don't have a native version of this, so we break it down into multiple ops, using a slightly modified formula from Hacker's Delight.The original formula does a floor average round, but we correct that by using a special shift right instruction that rounds up the result. I think this is correct, but would appreciate a double check on it.
This passes both the cranelift tests, as well as the wasmtime
*_arith2test suites, however we can't enable them yet because they also requireiabswhich is only implemented in #6598.